lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230817074000.355564-3-ruanjinjie@huawei.com> Date: Thu, 17 Aug 2023 15:39:59 +0800 From: Ruan Jinjie <ruanjinjie@...wei.com> To: <Shyam-sundar.S-k@....com>, <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>, <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>, <iyappan@...amperecomputing.com>, <keyur@...amperecomputing.com>, <quan@...amperecomputing.com>, <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>, <yankejian@...wei.com>, <netdev@...r.kernel.org> CC: <ruanjinjie@...wei.com> Subject: [PATCH net-next 2/3] amd-xgbe: Return proper error code for get_phy_device() get_phy_device() returns -EIO on bus access error and -ENOMEM on kzalloc failure in addition to -ENODEV, just return -ENODEV is not sensible, use PTR_ERR(phydev) to fix the issue. Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com> --- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c index 6a716337f48b..2f0a014ffc72 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c @@ -1090,7 +1090,7 @@ static int xgbe_phy_find_phy_device(struct xgbe_prv_data *pdata) (phy_data->phydev_mode == XGBE_MDIO_MODE_CL45)); if (IS_ERR(phydev)) { netdev_err(pdata->netdev, "get_phy_device failed\n"); - return -ENODEV; + return PTR_ERR(phydev); } netif_dbg(pdata, drv, pdata->netdev, "external PHY id is %#010x\n", phydev->phy_id); -- 2.34.1
Powered by blists - more mailing lists