lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230817080434.GF22185@unreal> Date: Thu, 17 Aug 2023 11:04:34 +0300 From: Leon Romanovsky <leon@...nel.org> To: Ruan Jinjie <ruanjinjie@...wei.com> Cc: Shyam-sundar.S-k@....com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, yisen.zhuang@...wei.com, salil.mehta@...wei.com, iyappan@...amperecomputing.com, keyur@...amperecomputing.com, quan@...amperecomputing.com, andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk, yankejian@...wei.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next 0/3] net: Fix return value check for get_phy_device() On Thu, Aug 17, 2023 at 03:39:57PM +0800, Ruan Jinjie wrote: > The get_phy_device() function returns error pointers and never > returns NULL. Update the checks accordingly. > > And get_phy_device() returns -EIO on bus access error and -ENOMEM > on kzalloc failure in addition to -ENODEV, return PTR_ERR is more > sensible. > > Ruan Jinjie (3): > net: mdio: Fix return value check for get_phy_device() > amd-xgbe: Return proper error code for get_phy_device() > net: hisilicon: hns: Fix return value check for get_phy_device() > > drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 2 +- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++-- > drivers/net/mdio/mdio-xgene.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists