lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8b4d4028-4141-085a-9375-d170fc98ad31@intel.com> Date: Fri, 18 Aug 2023 13:10:20 +0200 From: Przemek Kitszel <przemyslaw.kitszel@...el.com> To: Karol Kolacinski <karol.kolacinski@...el.com>, <intel-wired-lan@...ts.osuosl.org> CC: <netdev@...r.kernel.org>, <anthony.l.nguyen@...el.com>, <jesse.brandeburg@...el.com>, Jacob Keller <jacob.e.keller@...el.com> Subject: Re: [PATCH v2 iwl-next 1/9] ice: use ice_pf_src_tmr_owned where available On 8/17/23 16:17, Karol Kolacinski wrote: > The ice_pf_src_tmr_owned() macro exists to check the function capability This patch is send with you as an author. There should be a "From: Jacob Keller <jacob.e.keller@...el.com>" as first line. (git-send-email should do it for yourself, for testing: git log prior to sending should report Jake too) I remember that codewise v1 of this series was (about? :D) fine for me, will double check with v3. > bit indicating if the current function owns the PTP hardware clock. > > This is slightly shorter than the more verbose access via > hw.func_caps.ts_func_info.src_tmr_owned. Be consistent and use this > where possible rather than open coding its equivalent. > > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com> > Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com> > --- > drivers/net/ethernet/intel/ice/ice_main.c | 2 +- > drivers/net/ethernet/intel/ice/ice_ptp.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c > index a6dd336d2500..b6858f04152c 100644 > --- a/drivers/net/ethernet/intel/ice/ice_main.c > +++ b/drivers/net/ethernet/intel/ice/ice_main.c > @@ -3185,7 +3185,7 @@ static irqreturn_t ice_misc_intr(int __always_unused irq, void *data) > > ena_mask &= ~PFINT_OICR_TSYN_EVNT_M; > > - if (hw->func_caps.ts_func_info.src_tmr_owned) { > + if (ice_pf_src_tmr_owned(pf)) { > /* Save EVENTs from GLTSYN register */ > pf->ptp.ext_ts_irq |= gltsyn_stat & > (GLTSYN_STAT_EVENT0_M | > diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c > index 97b8581ae931..0669ca905c46 100644 > --- a/drivers/net/ethernet/intel/ice/ice_ptp.c > +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c > @@ -2447,7 +2447,7 @@ void ice_ptp_reset(struct ice_pf *pf) > if (test_bit(ICE_PFR_REQ, pf->state)) > goto pfr; > > - if (!hw->func_caps.ts_func_info.src_tmr_owned) > + if (!ice_pf_src_tmr_owned(pf)) > goto reset_ts; > > err = ice_ptp_init_phc(hw);
Powered by blists - more mailing lists