netdev - Re: [PATCH net-next] net: selectively purge error queue in IP_RECVERR / IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64dfb293d1052_2d6e1129458@willemb.c.googlers.com.notmuch>
Date: Fri, 18 Aug 2023 14:04:03 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Eric Dumazet <edumazet@...gle.com>, 
 "David S . Miller" <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, 
 eric.dumazet@...il.com, 
 Eric Dumazet <edumazet@...gle.com>, 
 Willem de Bruijn <willemb@...gle.com>, 
 Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH net-next] net: selectively purge error queue in IP_RECVERR
 / IPV6_RECVERR

Eric Dumazet wrote:
> Setting IP_RECVERR and IPV6_RECVERR options to zero currently
> purges the socket error queue, which was probably not expected
> for zerocopy and tx_timestamp users.
> 
> I discovered this issue while preparing commit 6b5f43ea0815
> ("inet: move inet->recverr to inet->inet_flags"), I presume this
> change does not need to be backported to stable kernels.
> 
> Add skb_errqueue_purge() helper to purge error messages only.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Cc: Soheil Hassas Yeganeh <soheil@...gle.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>