netdev - Re: [PATCH net v3 1/2] net: bgmac: Fix return value check for fixed_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230818185706.GJ22185@unreal>
Date: Fri, 18 Aug 2023 21:57:06 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Ruan Jinjie <ruanjinjie@...wei.com>
Cc: rafal@...ecki.pl, bcm-kernel-feedback-list@...adcom.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, opendmb@...il.com, florian.fainelli@...adcom.com,
	pgynther@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v3 1/2] net: bgmac: Fix return value check for
 fixed_phy_register()

On Fri, Aug 18, 2023 at 01:12:20PM +0800, Ruan Jinjie wrote:
> The fixed_phy_register() function returns error pointers and never
> returns NULL. Update the checks accordingly.
> 
> Fixes: c25b23b8a387 ("bgmac: register fixed PHY for ARM BCM470X / BCM5301X chipsets")
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
> v3:
> - Split the err code update code into another patch set as suggested.
> v2:
> - Remove redundant NULL check and fix the return value.
> - Update the commit title and message.
> - Add the fix tag.
> ---
>  drivers/net/ethernet/broadcom/bgmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>