netdev - Re: [PATCH net-next v2] e1000e: Use PME poll to circumvent unreliable ACPI wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230817191825.18711c80@kernel.org>
Date: Thu, 17 Aug 2023 19:18:25 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org, Kai-Heng Feng <kai.heng.feng@...onical.com>, Naama
 Meir <naamax.meir@...ux.intel.com>, Sasha Neftin <sasha.neftin@...el.com>,
 Simon Horman <simon.horman@...igine.com>, Leon Romanovsky
 <leonro@...dia.com>
Subject: Re: [PATCH net-next v2] e1000e: Use PME poll to circumvent
 unreliable ACPI wake

On Tue, 15 Aug 2023 10:01:11 -0700 Tony Nguyen wrote:
> From: Kai-Heng Feng <kai.heng.feng@...onical.com>
> 
> On some I219 devices, ethernet cable plugging detection only works once
> from PCI D3 state. Subsequent cable plugging does set PME bit correctly,
> but device still doesn't get woken up.
> 
> Since I219 connects to the root complex directly, it relies on platform
> firmware (ACPI) to wake it up. In this case, the GPE from _PRW only
> works for first cable plugging but fails to notify the driver for
> subsequent plugging events.
> 
> The issue was originally found on CNP, but the same issue can be found
> on ADL too. So workaround the issue by continuing use PME poll after
> first ACPI wake. As PME poll is always used, the runtime suspend
> restriction for CNP can also be removed.

Applied, thanks!

I'm curious - why not treat it as a fix?