netdev - Re: [netdev-next] net: release reference to inet6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 18 Aug 2023 10:06:04 +0200
From: Simon Horman <horms@...nel.org>
To: Patrick Rohr <prohr@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Linux Network Development Mailing List <netdev@...r.kernel.org>,
	Maciej Żenczykowski <maze@...gle.com>,
	Lorenzo Colitti <lorenzo@...gle.com>,
	David Ahern <dsahern@...nel.org>
Subject: Re: [netdev-next] net: release reference to inet6_dev pointer

On Wed, Aug 16, 2023 at 03:02:03PM -0700, Patrick Rohr wrote:
> addrconf_prefix_rcv returned early without releasing the inet6_dev
> pointer when the PIO lifetime is less than accept_ra_min_lft.
> 
> Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Lorenzo Colitti <lorenzo@...gle.com>
> Cc: David Ahern <dsahern@...nel.org>
> Signed-off-by: Patrick Rohr <prohr@...gle.com>

Hi Patrick,

this patch looks good to me, but unfortunately our CI got a bit
confused and tried to apply it to net, where it does not apply
because the cited commit is not present there, rather than
net-next, where it does apply. This creates a process issue for us.

I think it would be useful if you could repost the patch with
it targeted at net-next:

	Subject: [PATCH net-next] ...

Please feel free to include:

Reviewed-by: Simon Horman <horms@...nel.org>

-- 
pw-bot: changes-requested