netdev - Re: [PATCH net-next 0/3][pull request] virtchnl: fix fake 1-elem arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <169239782342.29271.2971755724203806921.git-patchwork-notify@kernel.org>
Date: Fri, 18 Aug 2023 22:30:23 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, netdev@...r.kernel.org, aleksander.lobakin@...el.com,
 andriy.shevchenko@...ux.intel.com, larysa.zaremba@...el.com,
 keescook@...omium.org, gustavoars@...nel.org
Subject: Re: [PATCH net-next 0/3][pull request] virtchnl: fix fake 1-elem arrays

Hello:

This series was applied to netdev/net-next.git (main)
by Tony Nguyen <anthony.l.nguyen@...el.com>:

On Wed, 16 Aug 2023 14:06:54 -0700 you wrote:
> Alexander Lobakin says:
> 
> 6.5-rc1 started spitting warning splats when composing virtchnl
> messages, precisely on virtchnl_rss_key and virtchnl_lut:
> 
> [   84.167709] memcpy: detected field-spanning write (size 52) of single
> field "vrk->key" at drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1095
> (size 1)
> [   84.169915] WARNING: CPU: 3 PID: 11 at drivers/net/ethernet/intel/
> iavf/iavf_virtchnl.c:1095 iavf_set_rss_key+0x123/0x140 [iavf]
> ...
> [   84.191982] Call Trace:
> [   84.192439]  <TASK>
> [   84.192900]  ? __warn+0xc9/0x1a0
> [   84.193353]  ? iavf_set_rss_key+0x123/0x140 [iavf]
> [   84.193818]  ? report_bug+0x12c/0x1b0
> [   84.194266]  ? handle_bug+0x42/0x70
> [   84.194714]  ? exc_invalid_op+0x1a/0x50
> [   84.195149]  ? asm_exc_invalid_op+0x1a/0x20
> [   84.195592]  ? iavf_set_rss_key+0x123/0x140 [iavf]
> [   84.196033]  iavf_watchdog_task+0xb0c/0xe00 [iavf]
> ...
> [   84.225476] memcpy: detected field-spanning write (size 64) of single
> field "vrl->lut" at drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1127
> (size 1)
> [   84.227190] WARNING: CPU: 27 PID: 1044 at drivers/net/ethernet/intel/
> iavf/iavf_virtchnl.c:1127 iavf_set_rss_lut+0x123/0x140 [iavf]
> ...
> [   84.246601] Call Trace:
> [   84.247228]  <TASK>
> [   84.247840]  ? __warn+0xc9/0x1a0
> [   84.248263]  ? iavf_set_rss_lut+0x123/0x140 [iavf]
> [   84.248698]  ? report_bug+0x12c/0x1b0
> [   84.249122]  ? handle_bug+0x42/0x70
> [   84.249549]  ? exc_invalid_op+0x1a/0x50
> [   84.249970]  ? asm_exc_invalid_op+0x1a/0x20
> [   84.250390]  ? iavf_set_rss_lut+0x123/0x140 [iavf]
> [   84.250820]  iavf_watchdog_task+0xb16/0xe00 [iavf]
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] virtchnl: fix fake 1-elem arrays in structs allocated as `nents + 1` - 1
    https://git.kernel.org/netdev/net-next/c/dd2e84bb3804
  - [net-next,2/3] virtchnl: fix fake 1-elem arrays in structures allocated as `nents + 1`
    https://git.kernel.org/netdev/net-next/c/5e7f59fa07f8
  - [net-next,3/3] virtchnl: fix fake 1-elem arrays for structures allocated as `nents`
    https://git.kernel.org/netdev/net-next/c/b0654e64dbaf

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html