netdev - RE: [PATCH net v2 0/2][pull request] igc: Enhance the tx-usecs coalesce setting implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 19 Aug 2023 13:22:58 +0000
From: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@...el.com>
To: Brett Creeley <bcreeley@....com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "Neftin, Sasha" <sasha.neftin@...el.com>, "horms@...nel.org"
	<horms@...nel.org>
Subject: RE: [PATCH net v2 0/2][pull request] igc: Enhance the tx-usecs
 coalesce setting implementation

> -----Original Message-----
> From: Brett Creeley <bcreeley@....com>
> Sent: Wednesday, 2 August, 2023 2:20 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com;
> edumazet@...gle.com; netdev@...r.kernel.org
> Cc: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>;
> Neftin, Sasha <sasha.neftin@...el.com>; horms@...nel.org
> Subject: Re: [PATCH net v2 0/2][pull request] igc: Enhance the tx-usecs
> coalesce setting implementation
> 
> On 8/1/2023 10:27 AM, Tony Nguyen wrote:
> > Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> >
> >
> > Muhammad Husaini Zulkifli says:
> >
> > The current tx-usecs coalesce setting implementation in the driver
> > code is improved by this patch series. The implementation of the
> > current driver code may have previously been a copy of the legacy code
> i210.
> >
> > Patch 1:
> > Allow the user to see the tx-usecs colease setting's current value
> > when using
> 
> nit, s/colease/coalesce

Sure. Will fix this typos.

> 
> > the ethtool command. The previous value was 0.
> >
> > Patch 2:
> > Give the user the ability to modify the tx-usecs colease setting's value.
> 
> nit, s/colease/coalesce

Noted. 

> 
> > Previously, it was restricted to rx-usecs.
> > ---
> > v2:
> > - Refactor the code, as Simon suggested, to make it more readable.
> >
> > v1:
> > https://lore.kernel.org/netdev/20230728170954.2445592-1-anthony.l.nguy
> > en@...el.com/
> >
> > The following are changes since commit
> 13d2618b48f15966d1adfe1ff6a1985f5eef40ba:
> >    bpf: sockmap: Remove preempt_disable in sock_map_sk_acquire and are
> > available in the git repository at:
> >    git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 1GbE
> >
> > Muhammad Husaini Zulkifli (2):
> >    igc: Expose tx-usecs coalesce setting to user
> >    igc: Modify the tx-usecs coalesce setting
> >
> >   drivers/net/ethernet/intel/igc/igc_ethtool.c | 62 +++++++++++++-------
> >   1 file changed, 41 insertions(+), 21 deletions(-)
> >
> > --
> > 2.38.1
> >
> >