lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <0ae6118c-59e1-4b9d-b4a7-270c69390f37@gmail.com> Date: Fri, 18 Aug 2023 17:27:27 -0700 From: Doug Berger <opendmb@...il.com> To: Ruan Jinjie <ruanjinjie@...wei.com>, rafal@...ecki.pl, bcm-kernel-feedback-list@...adcom.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, florian.fainelli@...adcom.com, bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next v3 2/3] net: bcmgenet: Return PTR_ERR() for fixed_phy_register() On 8/18/2023 12:07 AM, Ruan Jinjie wrote: > fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY, > etc, in addition to -ENODEV. The Best practice is to return these > error codes with PTR_ERR(). > > Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com> > --- > v3: > - Split the return value check into another patch set. > - Update the commit title and message. > --- > drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Doug Berger <opendmb@...il.com>
Powered by blists - more mailing lists