netdev - Re: [PATCH 10/18] nvme-tcp: improve icreq/icresp logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230818115034.x33sgaahkpp523rg@green245>
Date: Fri, 18 Aug 2023 17:20:34 +0530
From: Nitesh Shetty <nj.shetty@...sung.com>
To: Hannes Reinecke <hare@...e.de>
Cc: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, Keith
	Busch <kbusch@...nel.org>, linux-nvme@...ts.infradead.org, Jakub Kicinski
	<kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
	<pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 10/18] nvme-tcp: improve icreq/icresp logging

On 23/08/16 02:06PM, Hannes Reinecke wrote:
>When icreq/icresp fails we should be printing out a warning to
>inform the user that the connection could not be established;
>without it there won't be anything in the kernel message log,
>just an error code returned to nvme-cli.
>
>Signed-off-by: Hannes Reinecke <hare@...e.de>
>---
> drivers/nvme/host/tcp.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
>index e8e408dbb6ad..ef9cf8c7a113 100644
>--- a/drivers/nvme/host/tcp.c
>+++ b/drivers/nvme/host/tcp.c
>@@ -1403,8 +1403,11 @@ static int nvme_tcp_init_connection(struct nvme_tcp_queue *queue)
> 	iov.iov_base = icreq;
> 	iov.iov_len = sizeof(*icreq);
> 	ret = kernel_sendmsg(queue->sock, &msg, &iov, 1, iov.iov_len);
>-	if (ret < 0)
>+	if (ret < 0) {
>+		pr_warn("queue %d: failed to send icreq, error %d\n",
>+			nvme_tcp_queue_id(queue), ret);
> 		goto free_icresp;
>+	}
>
> 	memset(&msg, 0, sizeof(msg));
> 	iov.iov_base = icresp;
>@@ -1415,8 +1418,11 @@ static int nvme_tcp_init_connection(struct nvme_tcp_queue *queue)
> 	}
> 	ret = kernel_recvmsg(queue->sock, &msg, &iov, 1,
> 			iov.iov_len, msg.msg_flags);
>-	if (ret < 0)
>+	if (ret < 0) {
>+		pr_warn("queue %d: failed to receive icresp, error %d\n",
>+			nvme_tcp_queue_id(queue), ret);
> 		goto free_icresp;
>+	}
> 	if (queue->ctrl->ctrl.opts->tls) {
> 		ctype = tls_get_record_type(queue->sock->sk,
> 					    (struct cmsghdr *)cbuf);
>-- 
>2.35.3
>

Reviewed-by: Nitesh Shetty <nj.shetty@...sung.com>