netdev - Re: [Intel-wired-lan] [PATCH iwl-next 7/7] ice: Enable support for E830 device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd4b1f89-ffd5-421f-81bb-5715afaf7fca@molgen.mpg.de>
Date: Sat, 19 Aug 2023 07:03:05 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Paul Greenwalt <paul.greenwalt@...el.com>,
 Pawel Chmielewski <pawel.chmielewski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 7/7] ice: Enable support for
 E830 device IDs

Dear Pawel, dear Paul,


Thank you for the patch.

Am 17.08.23 um 01:57 schrieb Paul Greenwalt:
> From: Pawel Chmielewski <pawel.chmielewski@...el.com>

For the commit message summary, it sounds a little strange, how to 
enable support for a “device ID”. Maybe:

     ice: Add IDs of 4 E830 devices

or

     ice: Hook up 4 E830 devices by adding their IDs

> As the previous patches provide support for E830 hardware, add E830
> specific IDs to the PCI device ID table, so these devices can now be
> probed by the kernel.

If you could add a paragraph describing your test system and stating the 
test results, that would be very useful in my opinion.

> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Pawel Chmielewski <pawel.chmielewski@...el.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_main.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index d6715a89ec78..80013c839579 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5630,6 +5630,10 @@ static const struct pci_device_id ice_pci_tbl[] = {
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_10G_BASE_T)},
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_1GBE)},
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_QSFP)},
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_BACKPLANE)},
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_QSFP56)},
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_SFP)},
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_SFP_DD)},
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E822_SI_DFLT)},

I’d add the entries after all E822 entries, so they are kind of sorted.

>   	/* required last entry */
>   	{ 0, }


Kind regards,

Paul