netdev - Re: [PATCH net-next 5/5] selftests/tc-testing: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d95d8cfb-365d-619e-f987-b97fea02514d@mojatatu.com>
Date: Sat, 19 Aug 2023 17:48:04 -0300
From: Pedro Tammela <pctammela@...atatu.com>
To: netdev@...r.kernel.org
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, shuah@...nel.org, shaozhengchao@...wei.com,
 victor@...atatu.com
Subject: Re: [PATCH net-next 5/5] selftests/tc-testing: cls_u32: update tests

On 18/08/2023 13:35, Pedro Tammela wrote:
> Update the u32 tests to conform to the new syntax of a terminal flowid
> 
> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>
> ---
>   .../selftests/tc-testing/tc-tests/filters/u32.json     | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/u32.json b/tools/testing/selftests/tc-testing/tc-tests/filters/u32.json
> index ddc7c355be0a..d4b4c767d6c9 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/u32.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/u32.json
> @@ -15,7 +15,7 @@
>           "cmdUnderTest": "$TC filter add dev $DEV1 ingress protocol ip prio 1 u32 match ip src 127.0.0.1/32 flowid 1:1 action ok",
>           "expExitCode": "0",
>           "verifyCmd": "$TC filter show dev $DEV1 ingress",
> -        "matchPattern": "filter protocol ip pref 1 u32 chain (0[ ]+$|0 fh 800: ht divisor 1|0 fh 800::800 order 2048 key ht 800 bkt 0 flowid 1:1.*match 7f000001/ffffffff at 12)",
> +        "matchPattern": "filter protocol ip pref 1 u32 chain (0[ ]+$|0 fh 800: ht divisor 1|0 fh 800::800 order 2048 key ht 800 bkt 0 \\*flowid 1:1.*match 7f000001/ffffffff at 12)",
>           "matchCount": "3",
>           "teardown": [
>               "$TC qdisc del dev $DEV1 ingress"
> @@ -60,7 +60,7 @@
>           "cmdUnderTest": "$TC filter replace dev $DEV1 ingress protocol ip prio 1 u32 match ip src 127.0.0.2/32 indev notexist20 flowid 1:2 action ok",
>           "expExitCode": "2",
>           "verifyCmd": "$TC filter show dev $DEV1 ingress",
> -        "matchPattern": "filter protocol ip pref 1 u32 chain (0[ ]+$|0 fh 800: ht divisor 1|0 fh 800::800 order 2048 key ht 800 bkt 0 flowid 1:3.*match 7f000003/ffffffff at 12)",
> +        "matchPattern": "filter protocol ip pref 1 u32 chain (0[ ]+$|0 fh 800: ht divisor 1|0 fh 800::800 order 2048 key ht 800 bkt 0 \\*flowid 1:3.*match 7f000003/ffffffff at 12)",
>           "matchCount": "3",
>           "teardown": [
>               "$TC qdisc del dev $DEV1 ingress"
> @@ -196,7 +196,7 @@
>           "cmdUnderTest": "$TC filter replace dev $DEV1 ingress protocol ip prio 98 u32 ht 43:1 match tcp src 23 FFFF classid 1:4",
>           "expExitCode": "2",
>           "verifyCmd": "$TC filter show dev $DEV1 ingress",
> -        "matchPattern": "filter protocol ip pref 99 u32 chain (0[ ]+$|0 fh (43|800): ht divisor 1|0 fh 43::800 order 2048 key ht 43 bkt 0 flowid 1:3.*match 00160000/ffff0000 at nexthdr\\+0)",
> +        "matchPattern": "filter protocol ip pref 99 u32 chain (0[ ]+$|0 fh (43|800): ht divisor 1|0 fh 43::800 order 2048 key ht 43 bkt 0 \\*flowid 1:3.*match 00160000/ffff0000 at nexthdr\\+0)",
>           "matchCount": "4",
>           "teardown": [
>               "$TC qdisc del dev $DEV1 ingress"
> @@ -219,7 +219,7 @@
>           "cmdUnderTest": "bash -c \"for mask in ff ffff ffffff ffffffff ff00ff ff0000ff ffff00ff; do $TC filter add dev $DEV1 ingress prio 99 u32 ht 1: sample u32 0x10203040 \\$mask match u8 0 0 classid 1:1; done\"",
>           "expExitCode": "0",
>           "verifyCmd": "$TC filter show dev $DEV1 ingress",
> -        "matchPattern": "filter protocol all pref 99 u32( (chain|fh|order) [0-9:]+){3} key ht 1 bkt 40 flowid 1:1",
> +        "matchPattern": "filter protocol all pref 99 u32( (chain|fh|order) [0-9:]+){3} key ht 1 bkt 40 \\*flowid 1:1",
>           "matchCount": "7",
>           "teardown": [
>               "$TC qdisc del dev $DEV1 ingress"
> @@ -242,7 +242,7 @@
>           "cmdUnderTest": "bash -c \"for mask in 70 f0 ff0 fff0 ff00f0; do $TC filter add dev $DEV1 ingress prio 99 u32 ht 1: sample u32 0x10203040 \\$mask match u8 0 0 classid 1:1; done\"",
>           "expExitCode": "0",
>           "verifyCmd": "$TC filter show dev $DEV1 ingress",
> -        "matchPattern": "filter protocol all pref 99 u32( (chain|fh|order) [0-9:]+){3} key ht 1 bkt 4 flowid 1:1",
> +        "matchPattern": "filter protocol all pref 99 u32( (chain|fh|order) [0-9:]+){3} key ht 1 bkt 4 \\*flowid 1:1",
>           "matchCount": "5",
>           "teardown": [
>               "$TC qdisc del dev $DEV1 ingress"

Uh-oh, seems like this is broken again in iproute2-next.
Will double check...
-- 
pw-bot: cr