lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <86ba753a-f4a3-3d0f-1924-2b31666c3346@intel.com> Date: Mon, 21 Aug 2023 15:10:01 +0200 From: Alexander Lobakin <aleksander.lobakin@...el.com> To: Paul Greenwalt <paul.greenwalt@...el.com> CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>, "Jesse Brandeburg" <jesse.brandeburg@...el.com> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 8/9] ice: Remove redundant zeroing of the fields. From: Paul Greenwalt <paul.greenwalt@...el.com> Date: Sat, 19 Aug 2023 02:42:39 -0700 > From: Pawel Chmielewski <pawel.chmielewski@...el.com> > > Remove zeroing of the fields, as all the fields are in fact initialized > with zeros automatically > > Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com> > Signed-off-by: Pawel Chmielewski <pawel.chmielewski@...el.com> > Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com> > --- > drivers/net/ethernet/intel/ice/ice_main.c | 52 +++++++++++------------ > 1 file changed, 26 insertions(+), 26 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c > index ffed5543a5aa..d6715a89ec78 100644 > --- a/drivers/net/ethernet/intel/ice/ice_main.c > +++ b/drivers/net/ethernet/intel/ice/ice_main.c > @@ -5605,32 +5605,32 @@ static void ice_pci_err_reset_done(struct pci_dev *pdev) > * Class, Class Mask, private data (not used) } > */ > static const struct pci_device_id ice_pci_tbl[] = { > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_BACKPLANE), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_QSFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_SFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_BACKPLANE), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_QSFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_SFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_BACKPLANE), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_QSFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_SFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_10G_BASE_T), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_SGMII), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_BACKPLANE), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_QSFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_SFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_10G_BASE_T), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_SGMII), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822L_BACKPLANE), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822L_SFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822L_10G_BASE_T), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822L_SGMII), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_BACKPLANE), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_SFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_10G_BASE_T), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_1GBE), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_QSFP), 0 }, > - { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822_SI_DFLT), 0 }, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_BACKPLANE)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_QSFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_SFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_BACKPLANE)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_QSFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_SFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_BACKPLANE)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_QSFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_SFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_10G_BASE_T)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823C_SGMII)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_BACKPLANE)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_QSFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_SFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_10G_BASE_T)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822C_SGMII)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822L_BACKPLANE)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822L_SFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822L_10G_BASE_T)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822L_SGMII)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_BACKPLANE)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_SFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_10G_BASE_T)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_1GBE)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E823L_QSFP)}, > + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822_SI_DFLT)}, If you want to remove them, please keep the code style consistent. If you have a space after the opening brace (which is correct), leave a space before the closing one: { PCI_VDEVICE(INTEL, ICE_DEV_ID_E822_SI_DFLT) }, > /* required last entry */ > { 0, } Why wasn't this one addressed? :D /* required last entry */ { } or (saves 1 line): { /* required last entry */ } > }; Thanks, Olek
Powered by blists - more mailing lists