netdev - Re: [PATCH net] leds: trigger: netdev: rename 'hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f08d682-8dbb-4f93-aa2a-057ca7a74b9f@lunn.ch>
Date: Mon, 21 Aug 2023 15:20:42 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Marek Behún <kabel@...nel.org>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Christian Marangi <ansuelsmth@...il.com>
Subject: Re: [PATCH net] leds: trigger: netdev: rename 'hw_control' sysfs
 entry to 'offloaded'

On Mon, Aug 21, 2023 at 02:14:53PM +0200, Marek Behún wrote:
> Commit b655892ffd6d ("leds: trigger: netdev: expose hw_control status
> via sysfs") exposed to sysfs the flag that tells whether the LED trigger
> is offloaded to hardware, under the name "hw_control", since that is the
> name under which this setting is called in the code.
> 
> Everywhere else in kernel when some work that is normally done in
> software can be made to be done by hardware instead, we use the word
> "offloading" to describe this, e.g. "LED blinking is offloaded to
> hardware".

I agree with your reasoning.

> Normally renaming sysfs entries is a no-go because of backwards
> compatibility. But since this patch was not yet released in a stable
> kernel, I think it is still possible to rename it, if there is
> consensus.

As you say, this is still in net and so -rc7, not a released
kernel. But we are very close to the release.
 
> Fixes: b655892ffd6d ("leds: trigger: netdev: expose hw_control status via sysfs")
> Signed-off-by: Marek Behún <kabel@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew