lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <BLAPR15MB3874DB4725CD5B5139DAA868BC1EA@BLAPR15MB3874.namprd15.prod.outlook.com> Date: Mon, 21 Aug 2023 21:37:51 +0000 From: Vadim Fedorenko <vadfed@...a.com> To: Saeed Mahameed <saeed@...nel.org>, Jakub Kicinski <kuba@...nel.org> CC: Saeed Mahameed <saeedm@...dia.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>, Gal Pressman <gal@...dia.com>, Bar Shapira <bshapira@...dia.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Richard Cochran <richardcochran@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net] Revert "net/mlx5: Update cyclecounter shift value to improve ptp free running mode precision" Hi! I have tested the diff, looks like it works on both CX4 and CX6 cards I have right now. Wasn't able to find CX5 to test it, but I think it's ok to publish it and wait for some other users of CX5 to test. Best, Vadim ________________________________________ From: Saeed Mahameed <saeed@...nel.org> Sent: 17 August 2023 17:37 To: Jakub Kicinski Cc: Saeed Mahameed; Vadim Fedorenko; Rahul Rameshbabu; Gal Pressman; Bar Shapira; Vadim Fedorenko; Richard Cochran; netdev@...r.kernel.org Subject: Re: [PATCH net] Revert "net/mlx5: Update cyclecounter shift value to improve ptp free running mode precision" On 16 Aug 19:38, Jakub Kicinski wrote: >On Tue, 15 Aug 2023 08:15:07 -0700 Vadim Fedorenko wrote: >> From: Vadim Fedorenko <vadim.fedorenko@...ux.dev> >> >> This reverts commit 6a40109275626267ebf413ceda81c64719b5c431. >> >> There was an assumption in the original commit that all the devices >> supported by mlx5 advertise 1GHz as an internal timer frequency. >> Apparently at least ConnectX-4 Lx (MCX4431N-GCAN) provides 156.250Mhz >> as an internal frequency and the original commit breaks PTP >> synchronization on these cards. > >Hi Saeed, any preference here? Given we're past -rc6 and the small >size of the revert it seems like a tempting solution? Rahul's solution is also very small and already passed review, we will be conducting some tests, share the patch with Vadim for testing and I will be submitting it early next week. >
Powered by blists - more mailing lists