netdev - Re: [PATCH v4 21/28] net: wan: Add framer framework support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc5f1daa-58a1-fb86-65ba-c6b236051d45@csgroup.eu>
Date: Mon, 21 Aug 2023 05:19:22 +0000
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Linus Walleij <linus.walleij@...aro.org>
CC: Herve Codina <herve.codina@...tlin.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn
	<andrew@...n.ch>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Lee
 Jones <lee@...nel.org>, Qiang Zhao <qiang.zhao@....com>, Li Yang
	<leoyang.li@....com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>, Shengjiu Wang <shengjiu.wang@...il.com>, Xiubo Li
	<Xiubo.Lee@...il.com>, Fabio Estevam <festevam@...il.com>, Nicolin Chen
	<nicoleotsuka@...il.com>, Randy Dunlap <rdunlap@...radead.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "alsa-devel@...a-project.org"
	<alsa-devel@...a-project.org>, Thomas Petazzoni
	<thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 21/28] net: wan: Add framer framework support

Hi Linus,

Le 20/08/2023 à 23:06, Linus Walleij a écrit :
> On Fri, Aug 18, 2023 at 6:41 PM Christophe Leroy
> <christophe.leroy@...roup.eu> wrote:
> 
>> From: Herve Codina <herve.codina@...tlin.com>
>>
>> A framer is a component in charge of an E1/T1 line interface.
>> Connected usually to a TDM bus, it converts TDM frames to/from E1/T1
>> frames. It also provides information related to the E1/T1 line.
>>
>> The framer framework provides a set of APIs for the framer drivers
>> (framer provider) to create/destroy a framer and APIs for the framer
>> users (framer consumer) to obtain a reference to the framer, and
>> use the framer.
>>
>> This basic implementation provides a framer abstraction for:
>>   - power on/off the framer
>>   - get the framer status (line state)
>>   - be notified on framer status changes
>>   - get/set the framer configuration
>>
>> Signed-off-by: Herve Codina <herve.codina@...tlin.com>
>> Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>
>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> 
> I had these review comments, you must have missed them?
> https://lore.kernel.org/netdev/CACRpkdZQ9_f6+9CseV1L_wGphHujFPAYXMjJfjUrzSZRakOBzg@mail.gmail.com/
> 

As I said in the cover letter, this series only fixes critical build 
failures that happened when CONFIG_MODULES is set. The purpose was to 
allow robots to perform their job up to the end. Other feedback and 
comments will be taken into account by Hervé when he is back from holidays.

Thanks
Christophe