lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e167e97797a90d3d6ea09840ac909325537d6034.camel@sipsolutions.net> Date: Mon, 21 Aug 2023 11:44:29 +0200 From: Johannes Berg <johannes@...solutions.net> To: Evan Quan <evan.quan@....com>, gregkh@...uxfoundation.org, rafael@...nel.org, lenb@...nel.org, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, alexander.deucher@....com, andrew@...n.ch, rdunlap@...radead.org, quic_jjohnson@...cinc.com, horms@...nel.org Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, amd-gfx@...ts.freedesktop.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Mario Limonciello <mario.limonciello@....com> Subject: Re: [V9 4/9] wifi: mac80211: Add support for WBRF features On Fri, 2023-08-18 at 11:26 +0800, Evan Quan wrote: > To support the WBRF mechanism, Wifi adapters utilized in the system must > register the frequencies in use(or unregister those frequencies no longer > used) via the dedicated calls. So that, other drivers responding to the > frequencies can take proper actions to mitigate possible interference. > > Co-developed-by: Mario Limonciello <mario.limonciello@....com> > Signed-off-by: Mario Limonciello <mario.limonciello@....com> > Co-developed-by: Evan Quan <evan.quan@....com> > Signed-off-by: Evan Quan <evan.quan@....com> >From WiFi POV, this looks _almost_ fine to me. > +static void wbrf_get_ranges_from_chandef(struct cfg80211_chan_def *chandef, > + struct wbrf_ranges_in *ranges_in) > +{ > + u64 start_freq1, end_freq1; > + u64 start_freq2, end_freq2; > + int bandwidth; > + > + bandwidth = nl80211_chan_width_to_mhz(chandef->width); > + > + get_chan_freq_boundary(chandef->center_freq1, > + bandwidth, > + &start_freq1, > + &end_freq1); > + > + ranges_in->band_list[0].start = start_freq1; > + ranges_in->band_list[0].end = end_freq1; > + > + if (chandef->width == NL80211_CHAN_WIDTH_80P80) { > + get_chan_freq_boundary(chandef->center_freq2, > + bandwidth, > + &start_freq2, > + &end_freq2); > + > + ranges_in->band_list[1].start = start_freq2; > + ranges_in->band_list[1].end = end_freq2; > + } > +} This has to setup ranges_in->num_of_ranges, no? (Also no real good reason for num_of_ranges to be a u64, btw, since it can only go up to 11) With that fixed, you can add Reviewed-by: Johannes Berg <johannes@...solutions.net> johannes
Powered by blists - more mailing lists