netdev - Re: [EXTERNAL] Re: [PATCH v2 2/5] dt-bindings: net: Add iep property in ICSSG dt binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73169382-dd0a-ddb7-caf6-ba9a783736fe@ti.com>
Date: Tue, 22 Aug 2023 16:25:34 +0530
From: Md Danish Anwar <a0501179@...com>
To: Rob Herring <robh@...nel.org>, MD Danish Anwar <danishanwar@...com>
CC: Randy Dunlap <rdunlap@...radead.org>, Roger Quadros <rogerq@...nel.org>,
        Simon Horman <simon.horman@...igine.com>,
        Vignesh Raghavendra
	<vigneshr@...com>, Andrew Lunn <andrew@...n.ch>,
        Richard Cochran
	<richardcochran@...il.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Paolo Abeni
	<pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet
	<edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>, <nm@...com>, <srk@...com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXTERNAL] Re: [PATCH v2 2/5] dt-bindings: net: Add iep property
 in ICSSG dt binding

Hi Rob,

On 22/08/23 3:29 pm, Md Danish Anwar wrote:
> Hi Rob,
> 
> On 21/08/23 9:31 pm, Rob Herring wrote:
>> On Mon, Aug 07, 2023 at 04:30:45PM +0530, MD Danish Anwar wrote:
>>> Add iep node in ICSSG driver dt binding document.
>>
>> Why?
>>
>> Bindings are for h/w, not drivers. You are adding a property, not a 
> 
> I will change the above to "Add IEP property in ICSSG hardware DT binding
> document."
> 
>> node. Would be nice to know what 'iep' is without having to look at the 
>> diff (e.g. when running 'git log').
>>
> 
> Sure, I will provide description of IEP in the commit message.
> 

I will change the commit message to below.

    dt-bindings: net: Add IEP property in ICSSG

    Add IEP property in ICSSG hardware DT binding document.
    ICSSG uses IEP (Industrial Ethernet Peripheral) to support timestamping
    of ethernet packets, PTP and PPS.

Please let me know if this looks OK to you.

>>>
>>> Signed-off-by: MD Danish Anwar <danishanwar@...com>
>>> ---
>>>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> index 8ec30b3eb760..36870238f92f 100644
>>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> @@ -52,6 +52,12 @@ properties:
>>>      description:
>>>        phandle to MII_RT module's syscon regmap
>>>  
>>> +  ti,iep:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>>
>> phandle-array really means matrix, so you need to fully describe the 
>> items constraints.
>>
>>> +    maxItems: 2
>>
>> 2 phandles or 1 phandle and 1 arg? Looks like the former from the 
> 
> It's 2 phandles.
> 
>> example, so:
>>
>> maxItems: 2
>> items:
>>   maxItems: 1
>>
> 
> Sure, I will change the item constraints to above.
> 
>>> +    description:
>>> +      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
>>> +
>>>    interrupts:
>>>      maxItems: 2
>>>      description:
>>> @@ -155,6 +161,7 @@ examples:
>>>                      "tx1-0", "tx1-1", "tx1-2", "tx1-3",
>>>                      "rx0", "rx1";
>>>          ti,mii-g-rt = <&icssg2_mii_g_rt>;
>>> +        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
>>>          interrupt-parent = <&icssg2_intc>;
>>>          interrupts = <24 0 2>, <25 1 3>;
>>>          interrupt-names = "tx_ts0", "tx_ts1";
>>> -- 
>>> 2.34.1
>>>
> 

-- 
Thanks and Regards,
Danish.