netdev - Re: [PATCH 4/6] dt-bindings: net: microchip: Allow nvmem-cell usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4855037.31r3eYUQgx@steina-w>
Date: Tue, 22 Aug 2023 13:28:10 +0200
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Rob Herring <robh@...nel.org>
Cc: Eric Dumazet <edumazet@...gle.com>, Pengutronix Kernel Team <kernel@...gutronix.de>, NXP Linux Team <linux-imx@....com>, Fabio Estevam <festevam@...il.com>, linux-pm@...r.kernel.org, David Airlie <airlied@...il.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Amit Kucheria <amitk@...nel.org>, Zhang Rui <rui.zhang@...el.com>, "Rafael J . Wysocki" <rafael@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, devicetree@...r.kernel.org, netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, linux-arm-kernel@...ts.infradead.org, Sascha Hauer <s.hauer@...gutronix.de>, Thomas Gleixner <tglx@...utronix.de>, Daniel Vetter <daniel@...ll.ch>, Rob Herring <robh+dt@...nel.org>, Jakub Kicinski <kuba@...nel.org>, "David S . Miller" <davem@...emloft.net>, dri-devel@...ts.freedesktop.org, Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH 4/6] dt-bindings: net: microchip: Allow nvmem-cell usage

Am Montag, 21. August 2023, 19:14:39 CEST schrieb Rob Herring:
> On Thu, 10 Aug 2023 16:44:49 +0200, Alexander Stein wrote:
> > MAC address can be provided by a nvmem-cell, thus allow referencing a
> > source for the address. Fixes the warning:
> > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names',
> > 
> >  'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> >  From schema: Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> > ---
> > 
> >  Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

Thanks. But while reading your comment on patch 3, I'm wondering if 
additionalProperties should be changed to unevaluatedProperties here as well.
This way local-mac-address and mac-address canbe removed as well, they are 
defined in ethernet-controller.yaml already.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/