netdev - RE: [PATCH v3 8/9] io_uring/cmd: BPF hook for getsockopt cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <687cf089ecc5451d9e398d71c9e171f0@AcuMS.aculab.com>
Date: Tue, 22 Aug 2023 13:50:45 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Breno Leitao' <leitao@...ian.org>, Gabriel Krisman Bertazi
	<krisman@...e.de>
CC: "sdf@...gle.com" <sdf@...gle.com>, "axboe@...nel.dk" <axboe@...nel.dk>,
	"asml.silence@...il.com" <asml.silence@...il.com>,
	"willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
	"martin.lau@...ux.dev" <martin.lau@...ux.dev>, "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "io-uring@...r.kernel.org"
	<io-uring@...r.kernel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>
Subject: RE: [PATCH v3 8/9] io_uring/cmd: BPF hook for getsockopt cmd

...
> Not really, sock->ops->getsockopt() does not suport sockptr_t, but
> __user addresses, differently from setsockopt()
> 
...
>           int             (*getsockopt)(struct socket *sock, int level,
>                                         int optname, char __user *optval, int __user *optlen);
> 
> In order to be able to call sock->ops->getsockopt(), the callback
> function will need to accepted sockptr.

It is also worth looking at whether 'optlen' can be passed in
as a numeric parameter and then returned on success.
That would move the user copy into the syscall wrapper.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)