netdev - Re: [PATCH net-next] vrf: Remove unnecessary RCU-bh critical section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9884f61a-8a92-cf18-6477-11b4dd12ce6b@kernel.org>
Date: Tue, 22 Aug 2023 08:29:42 -0700
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, mlxsw@...dia.com
Subject: Re: [PATCH net-next] vrf: Remove unnecessary RCU-bh critical section

On 8/21/23 8:23 AM, Ido Schimmel wrote:
> dev_queue_xmit_nit() already uses rcu_read_lock() / rcu_read_unlock()
> and nothing suggests that softIRQs should be disabled around it.
> Therefore, remove the rcu_read_lock_bh() / rcu_read_unlock_bh()
> surrounding it.
> 
> Tested using [1] with lockdep enabled.
> 
> [1]
>  #!/bin/bash
> 
>  ip link add name vrf1 up type vrf table 100
>  ip link add name veth0 type veth peer name veth1
>  ip link set dev veth1 master vrf1
>  ip link set dev veth0 up
>  ip link set dev veth1 up
>  ip address add 192.0.2.1/24 dev veth0
>  ip address add 192.0.2.2/24 dev veth1
>  ip rule add pref 32765 table local
>  ip rule del pref 0
>  tcpdump -i vrf1 -c 20 -w /dev/null &
>  sleep 10
>  ping -i 0.1 -c 10 -q 192.0.2.2
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  drivers/net/vrf.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>