netdev - Re: [PATCH bpf-next 4/6] samples/bpf: Remove the xdp1 and xdp2 utilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 22 Aug 2023 17:51:05 +0200
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Toke Høiland-Jørgensen <toke@...hat.com>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org,
 Samuel Dobron <sdobron@...hat.com>, Ondrej Lichtner <olichtne@...hat.com>,
 Rick Alongi <ralongi@...hat.com>
Subject: Re: [PATCH bpf-next 4/6] samples/bpf: Remove the xdp1 and xdp2
 utilities

On 22/08/2023 16.22, Toke Høiland-Jørgensen wrote:
> The functionality of these utilities have been incorporated into the
> xdp-bench utility in xdp-tools. Remove the unmaintained versions in
> samples.
> 

I think it will be worth our time if we give some examples of how the
removed utility translates to some given xdp-bench commands.  There is
not a 1-1 mapping.

XDP driver changes need to be verified on physical NIC hardware, so
these utilities are still being run by QA.  I know Red Hat, Intel and
Linaro QA people are using these utilities.  It will save us time if we
can reference a commit message instead of repeatable describing this.
E.g. for Intel is it often contingent workers that adds a tested-by
(that all need to update their knowledge).

Red Hat is in the process of moving our QA to use xdp-bench / xdp-tools.

Want to mention LNST team are also adding xdp-bench (+pktgen) support:
  - https://github.com/LNST-project/lnst/pull/310

--Jesper

> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> ---
>   samples/bpf/Makefile    |   7 --
>   samples/bpf/xdp1_kern.c | 100 ------------------------
>   samples/bpf/xdp1_user.c | 166 ----------------------------------------
>   samples/bpf/xdp2_kern.c | 125 ------------------------------
>   4 files changed, 398 deletions(-)
>   delete mode 100644 samples/bpf/xdp1_kern.c
>   delete mode 100644 samples/bpf/xdp1_user.c
>   delete mode 100644 samples/bpf/xdp2_kern.c