netdev - Re: [PATCH bpf-next 4/6] samples/bpf: Remove the xdp1 and xdp2 utilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3d2080d-e593-283b-cf97-d39256cfd4e9@redhat.com>
Date: Tue, 22 Aug 2023 19:04:41 +0200
From: Jesper Dangaard Brouer <jbrouer@...hat.com>
To: Toke Høiland-Jørgensen <toke@...hat.com>,
 Jesper Dangaard Brouer <hawk@...nel.org>, Alexei Starovoitov
 <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>
Cc: brouer@...hat.com, bpf@...r.kernel.org, netdev@...r.kernel.org,
 Samuel Dobron <sdobron@...hat.com>, Ondrej Lichtner <olichtne@...hat.com>,
 Rick Alongi <ralongi@...hat.com>
Subject: Re: [PATCH bpf-next 4/6] samples/bpf: Remove the xdp1 and xdp2
 utilities

On 22/08/2023 18.56, Toke Høiland-Jørgensen wrote:
> Jesper Dangaard Brouer <hawk@...nel.org> writes:
> 
>> On 22/08/2023 16.22, Toke Høiland-Jørgensen wrote:
>>> The functionality of these utilities have been incorporated into the
>>> xdp-bench utility in xdp-tools. Remove the unmaintained versions in
>>> samples.
>>>
>>
>> I think it will be worth our time if we give some examples of how the
>> removed utility translates to some given xdp-bench commands.  There is
>> not a 1-1 mapping.
>>
>> XDP driver changes need to be verified on physical NIC hardware, so
>> these utilities are still being run by QA.  I know Red Hat, Intel and
>> Linaro QA people are using these utilities.  It will save us time if we
>> can reference a commit message instead of repeatable describing this.
>> E.g. for Intel is it often contingent workers that adds a tested-by
>> (that all need to update their knowledge).
> 
> I did think about putting that in the commit message for these, but I
> figured it was too obscure a place to put it, compared to (for instance)
> putting it into the xdp-bench man page.
> 
> If you prefer to have it in the commit message as well, I can respin
> adding it - WDYT?
> 

It is super nice that xdp-bench already have a man page, but I was 
actually looking at this and it was a bit overwhelming (520 lines) 
explaining every possible option.

I really think its worth giving examples in the commit, to ease the 
transition to this new tool.

--Jesper
p.s. man page is generated from the readme [1]:
  [1] 
https://github.com/xdp-project/xdp-tools/blob/master/xdp-bench/README.org