netdev - Re: [PATCH net] sfc: allocate a big enough SKB for loopback selftest packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 22 Aug 2023 18:20:23 +0000
From: patchwork-bot+netdevbpf@...nel.org
To:  <edward.cree@....com>
Cc: linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org,
 edumazet@...gle.com, pabeni@...hat.com, ecree.xilinx@...il.com,
 netdev@...r.kernel.org, habetsm.xilinx@...il.com, andy.moreton@....com
Subject: Re: [PATCH net] sfc: allocate a big enough SKB for loopback selftest
 packet

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 21 Aug 2023 19:01:53 +0100 you wrote:
> From: Edward Cree <ecree.xilinx@...il.com>
> 
> Cited commits passed a size to alloc_skb that was only big enough for
>  the actual packet contents, but the following skb_put + memcpy writes
>  the whole struct efx_loopback_payload including leading and trailing
>  padding bytes (which are then stripped off with skb_pull/skb_trim).
> This could cause an skb_over_panic, although in practice we get saved
>  by kmalloc_size_roundup.
> Pass the entire size we use, instead of the size of the final packet.
> 
> [...]

Here is the summary with links:
  - [net] sfc: allocate a big enough SKB for loopback selftest packet
    https://git.kernel.org/netdev/net/c/6dc5774deefe

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html