netdev - Re: [PATCH net-next 3/3] net: l2tp_eth: use generic dev->stats fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 22 Aug 2023 11:35:40 +0800
From: kernel test robot <lkp@...el.com>
To: Eric Dumazet <edumazet@...gle.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, "Michael S . Tsirkin" <mst@...hat.com>,
	Jason Wang <jasowang@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 3/3] net: l2tp_eth: use generic dev->stats fields

Hi Eric,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/net-add-DEV_STATS_READ-helper/20230821-110051
base:   net-next/main
patch link:    https://lore.kernel.org/r/20230819044059.833749-4-edumazet%40google.com
patch subject: [PATCH net-next 3/3] net: l2tp_eth: use generic dev->stats fields
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20230822/202308221115.YXoSl0BK-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230822/202308221115.YXoSl0BK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308221115.YXoSl0BK-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/l2tp/l2tp_eth.c: In function 'l2tp_eth_dev_recv':
>> net/l2tp/l2tp_eth.c:121:26: warning: variable 'priv' set but not used [-Wunused-but-set-variable]
     121 |         struct l2tp_eth *priv;
         |                          ^~~~


vim +/priv +121 net/l2tp/l2tp_eth.c

d9e31d17ceba5f James Chapman    2010-04-02  116  
d9e31d17ceba5f James Chapman    2010-04-02  117  static void l2tp_eth_dev_recv(struct l2tp_session *session, struct sk_buff *skb, int data_len)
d9e31d17ceba5f James Chapman    2010-04-02  118  {
d9e31d17ceba5f James Chapman    2010-04-02  119  	struct l2tp_eth_sess *spriv = l2tp_session_priv(session);
ee28de6bbd78c2 Guillaume Nault  2017-10-27  120  	struct net_device *dev;
ee28de6bbd78c2 Guillaume Nault  2017-10-27 @121  	struct l2tp_eth *priv;
d9e31d17ceba5f James Chapman    2010-04-02  122  
c0cc88a7627c33 Eric Dumazet     2012-09-04  123  	if (!pskb_may_pull(skb, ETH_HLEN))
d9e31d17ceba5f James Chapman    2010-04-02  124  		goto error;
d9e31d17ceba5f James Chapman    2010-04-02  125  
d9e31d17ceba5f James Chapman    2010-04-02  126  	secpath_reset(skb);
d9e31d17ceba5f James Chapman    2010-04-02  127  
d9e31d17ceba5f James Chapman    2010-04-02  128  	/* checksums verified by L2TP */
d9e31d17ceba5f James Chapman    2010-04-02  129  	skb->ip_summed = CHECKSUM_NONE;
d9e31d17ceba5f James Chapman    2010-04-02  130  
d9e31d17ceba5f James Chapman    2010-04-02  131  	skb_dst_drop(skb);
895b5c9f206eb7 Florian Westphal 2019-09-29  132  	nf_reset_ct(skb);
d9e31d17ceba5f James Chapman    2010-04-02  133  
ee28de6bbd78c2 Guillaume Nault  2017-10-27  134  	rcu_read_lock();
ee28de6bbd78c2 Guillaume Nault  2017-10-27  135  	dev = rcu_dereference(spriv->dev);
ee28de6bbd78c2 Guillaume Nault  2017-10-27  136  	if (!dev)
ee28de6bbd78c2 Guillaume Nault  2017-10-27  137  		goto error_rcu;
ee28de6bbd78c2 Guillaume Nault  2017-10-27  138  
ee28de6bbd78c2 Guillaume Nault  2017-10-27  139  	priv = netdev_priv(dev);
d9e31d17ceba5f James Chapman    2010-04-02  140  	if (dev_forward_skb(dev, skb) == NET_RX_SUCCESS) {
b9494cd37a920d Eric Dumazet     2023-08-19  141  		DEV_STATS_INC(dev, rx_packets);
b9494cd37a920d Eric Dumazet     2023-08-19  142  		DEV_STATS_ADD(dev, rx_bytes, data_len);
a2842a1e663297 Eric Dumazet     2012-06-25  143  	} else {
b9494cd37a920d Eric Dumazet     2023-08-19  144  		DEV_STATS_INC(dev, rx_errors);
a2842a1e663297 Eric Dumazet     2012-06-25  145  	}
ee28de6bbd78c2 Guillaume Nault  2017-10-27  146  	rcu_read_unlock();
ee28de6bbd78c2 Guillaume Nault  2017-10-27  147  
d9e31d17ceba5f James Chapman    2010-04-02  148  	return;
d9e31d17ceba5f James Chapman    2010-04-02  149  
ee28de6bbd78c2 Guillaume Nault  2017-10-27  150  error_rcu:
ee28de6bbd78c2 Guillaume Nault  2017-10-27  151  	rcu_read_unlock();
d9e31d17ceba5f James Chapman    2010-04-02  152  error:
d9e31d17ceba5f James Chapman    2010-04-02  153  	kfree_skb(skb);
d9e31d17ceba5f James Chapman    2010-04-02  154  }
d9e31d17ceba5f James Chapman    2010-04-02  155  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki