netdev - Re: [PATCH stable 4.14] net: phy: broadcom: stub c45 read/write for 54810

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023082252-motor-grower-5621@gregkh>
Date: Tue, 22 Aug 2023 09:10:02 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: stable@...r.kernel.org, Justin Chen <justin.chen@...adcom.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	"open list:BROADCOM ETHERNET PHY DRIVERS" <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH stable 4.14] net: phy: broadcom: stub c45 read/write for
 54810

On Mon, Aug 21, 2023 at 02:54:10PM -0700, Florian Fainelli wrote:
> From: Justin Chen <justin.chen@...adcom.com>
> 
> commit 096516d092d54604d590827d05b1022c8f326639 upstream
> 
> The 54810 does not support c45. The mmd_phy_indirect accesses return
> arbirtary values leading to odd behavior like saying it supports EEE
> when it doesn't. We also see that reading/writing these non-existent
> MMD registers leads to phy instability in some cases.
> 
> Fixes: b14995ac2527 ("net: phy: broadcom: Add BCM54810 PHY entry")
> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Link: https://lore.kernel.org/r/1691901708-28650-1-git-send-email-justin.chen@broadcom.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> [florian: resolved conflicts in 4.14]
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>

Thanks for these, all now queued up.

greg k-h