netdev - [PATCH net-next] net: dsa: rzn1-a5psw: remove redundant logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230822084112.54803-1-alexis.lothore@bootlin.com>
Date: Tue, 22 Aug 2023 10:41:12 +0200
From: Alexis Lothoré <alexis.lothore@...tlin.com>
To: Clément Leger <clement@...ment-leger.fr>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>
Cc: linux-renesas-soc@...r.kernel.org,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Milan Stevanovic <milan.stevanovic@...com>,
	Jimmy Lalande <jimmy.lalande@...com>,
	Pascal Eberhard <pascal.eberhard@...com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: [PATCH net-next] net: dsa: rzn1-a5psw: remove redundant logs

From: Alexis Lothoré <alexis.lothore@...tlin.com>

Remove debug logs in port vlan management, since there are already multiple
tracepoints defined for those operations in DSA

Signed-off-by: Alexis Lothoré <alexis.lothore@...tlin.com>
---
This update is a follow-up to Vladimir Oltean's comment (see [1]) which has
not been addressed before the RZN1 A5PSW vlan series merge

[1] https://lore.kernel.org/netdev/20230811100613.o77ei6updvbndkjm@skbuf/
---
 drivers/net/dsa/rzn1_a5psw.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
index 9167e83fbceb..2eda10b33f2e 100644
--- a/drivers/net/dsa/rzn1_a5psw.c
+++ b/drivers/net/dsa/rzn1_a5psw.c
@@ -735,10 +735,6 @@ static int a5psw_port_vlan_add(struct dsa_switch *ds, int port,
 	u16 vid = vlan->vid;
 	int vlan_res_id;
 
-	dev_dbg(a5psw->dev, "Add VLAN %d on port %d, %s, %s\n",
-		vid, port, tagged ? "tagged" : "untagged",
-		pvid ? "PVID" : "no PVID");
-
 	vlan_res_id = a5psw_find_vlan_entry(a5psw, vid);
 	if (vlan_res_id < 0) {
 		vlan_res_id = a5psw_new_vlan_res_entry(a5psw, vid);
@@ -767,8 +763,6 @@ static int a5psw_port_vlan_del(struct dsa_switch *ds, int port,
 	u16 vid = vlan->vid;
 	int vlan_res_id;
 
-	dev_dbg(a5psw->dev, "Removing VLAN %d on port %d\n", vid, port);
-
 	vlan_res_id = a5psw_find_vlan_entry(a5psw, vid);
 	if (vlan_res_id < 0)
 		return -EINVAL;
-- 
2.41.0