lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230822170335.671f3bef@kernel.org> Date: Tue, 22 Aug 2023 17:03:35 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Jinjie Ruan <ruanjinjie@...wei.com> Cc: <rafal@...ecki.pl>, <bcm-kernel-feedback-list@...adcom.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>, <opendmb@...il.com>, <florian.fainelli@...adcom.com>, <bryan.whitehead@...rochip.com>, <UNGLinuxDriver@...rochip.com>, <netdev@...r.kernel.org>, <andrew@...n.ch> Subject: Re: [PATCH net-next v4 3/3] net: lan743x: Return PTR_ERR() for fixed_phy_register() On Mon, 21 Aug 2023 10:50:20 +0800 Jinjie Ruan wrote: > fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY, > etc, in addition to -EIO. The Best practice is to return these > error codes with PTR_ERR(). EPROBE_DEFER is not a unix error code. We can't return it to user space, so propagating it from ndo_open is not correct. > diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c > index a36f6369f132..c81cdeb4d4e7 100644 > --- a/drivers/net/ethernet/microchip/lan743x_main.c > +++ b/drivers/net/ethernet/microchip/lan743x_main.c > @@ -1515,7 +1515,7 @@ static int lan743x_phy_open(struct lan743x_adapter *adapter) > &fphy_status, NULL); > if (IS_ERR(phydev)) { > netdev_err(netdev, "No PHY/fixed_PHY found\n"); > - return -EIO; > + return PTR_ERR(phydev); > } > } else { > goto return_error;
Powered by blists - more mailing lists