netdev - Re: [PATCH 7/12] mptcp: Do not include crypto/algapi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 23 Aug 2023 14:53:56 +0200
From: Matthieu Baerts <matthieu.baerts@...sares.net>
To: Herbert Xu <herbert@...dor.apana.org.au>,
 Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
 Eric Biggers <ebiggers@...nel.org>, "Theodore Y. Ts'o" <tytso@....edu>,
 Jaegeuk Kim <jaegeuk@...nel.org>, linux-fscrypt@...r.kernel.org,
 Richard Weinberger <richard@....at>, linux-mtd@...ts.infradead.org,
 Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 linux-bluetooth@...r.kernel.org, Ilya Dryomov <idryomov@...il.com>,
 Xiubo Li <xiubli@...hat.com>, Jeff Layton <jlayton@...nel.org>,
 ceph-devel@...r.kernel.org, Steffen Klassert <steffen.klassert@...unet.com>,
 "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
 Johannes Berg <johannes@...solutions.net>, linux-wireless@...r.kernel.org,
 Mat Martineau <martineau@...nel.org>, Chuck Lever <chuck.lever@...cle.com>,
 Neil Brown <neilb@...e.de>, linux-nfs@...r.kernel.org,
 Mimi Zohar <zohar@...ux.ibm.com>, linux-integrity@...r.kernel.org,
 "Jason A. Donenfeld" <Jason@...c4.com>, Ayush Sawal <ayush.sawal@...lsio.com>
Subject: Re: [PATCH 7/12] mptcp: Do not include crypto/algapi.h

Hello,

On 23/08/2023 12:32, Herbert Xu wrote:
> The header file crypto/algapi.h is for internal use only.  Use the
> header file crypto/utils.h instead.

Thank you for the patch! It looks good to me:

Acked-by: Matthieu Baerts <matthieu.baerts@...sares.net>

I understood that other patches will come later to make it clear
crypto/algapi.h is for internal use only so that's good!

> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
> index 9ee3b7abbaf6..64bb200099dc 100644
> --- a/net/mptcp/subflow.c
> +++ b/net/mptcp/subflow.c
> @@ -9,8 +9,8 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/netdevice.h>
> -#include <crypto/algapi.h>
>  #include <crypto/sha2.h>
> +#include <crypto/utils.h>

It is fine for me if you carry this patch in your tree: this part here
has not changed for a while and there is no ongoing work going to modify
it. So there should not be any conflicts when merging the different
trees later.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net