netdev - Re: [PATCH net-next v3 7/8] net: txgbe: support copper NIC with external PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d999689-cea9-4e66-8807-a04eb9ad4cb5@lunn.ch>
Date: Wed, 23 Aug 2023 17:35:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, hkallweit1@...il.com,
	linux@...linux.org.uk, Jose.Abreu@...opsys.com,
	rmk+kernel@...linux.org.uk, mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v3 7/8] net: txgbe: support copper NIC with
 external PHY

> +static int txgbe_phy_read(struct mii_bus *bus, int phy_addr,
> +			  int devnum, int regnum)

There is a general pattern to use the postfix _c45 for the method that
implements C45 access. Not a must, just a nice to have.

Does this bus master not support C22 at all?

     Andrew