netdev - Re: [PATCH] ipv6/addrconf: clamp preferred_lft to the minimum instead of erroring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f980abd-498a-8de8-2c62-0882bc1d3369@kernel.org>
Date: Tue, 22 Aug 2023 20:45:12 -0700
From: David Ahern <dsahern@...nel.org>
To: Alex Henrie <alexhenrie24@...il.com>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, jbohac@...e.cz, benoit.boissinot@...-lyon.org,
 davem@...emloft.net, hideaki.yoshifuji@...aclelinux.com
Subject: Re: [PATCH] ipv6/addrconf: clamp preferred_lft to the minimum instead
 of erroring

On 8/22/23 9:41 PM, Alex Henrie wrote:
> Hi Paolo, thanks for the review.
> 
> On Tue, Aug 22, 2023 at 3:54 AM Paolo Abeni <pabeni@...hat.com> wrote:
> 
>> It looks like you are fixing 2 separate bugs, so 2 separate patches
>> would be better.
> 
> The two problems are closely related, and in the same function. But I
> will split the patch into two patches to your preference.
> 
>> You should explicitly state the target tree (in this case 'net') into
>> the patch subj.
> 
> Will fix in v2, thanks.
> 
>> You should add a suitable fixes tag to each patch.
> 
> That would be "Fixes: 76506a986dc31394fd1f2741db037d29c7e57843" and
> "Fixes: eac55bf97094f6b64116426864cf4666ef7587bc", correct?

See `git log` and search for Fixes to see examples. e.g.,

Fixes: eac55bf97094 ("IPv6: do not create temporary adresses with too
short preferred lifetime")