netdev - Re: [PATCH net-next v3 07/12] tools/net/ynl: Add support for netlink-raw families

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2v8d6gqsc.fsf@gmail.com>
Date: Wed, 23 Aug 2023 08:29:39 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: netdev@...r.kernel.org
Cc: Jakub Kicinski <kuba@...nel.org>,  "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Paolo Abeni
 <pabeni@...hat.com>,  Jonathan Corbet <corbet@....net>,
  linux-doc@...r.kernel.org,  Stanislav Fomichev <sdf@...gle.com>,
  Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
  donald.hunter@...hat.com
Subject: Re: [PATCH net-next v3 07/12] tools/net/ynl: Add support for
 netlink-raw families

Donald Hunter <donald.hunter@...il.com> writes:
>
> -    def handle_ntf(self, nl_msg, genl_msg):
> +    def handle_ntf(self, decoded):
>          msg = dict()
>          if self.include_raw:
> -            msg['nlmsg'] = nl_msg
> -            msg['genlmsg'] = genl_msg
> -        op = self.rsp_by_value[genl_msg.genl_cmd]
> +            msg['raw'] = decoded
> +        op = self.rsp_by_value[decoded.cmd()]
> +        attrs = self._decode(decoded.raw_attrs, op.attr_set.name)
> +        if op.fixed_header:
> +            attrs.update(self._decode_fixed_header(gm, op.fixed_header))

There's a mistake here, 'gm' should be 'decoded'. I'll fix in a v4.

> +
>          msg['name'] = op['name']
> -        msg['msg'] = self._decode(genl_msg.raw_attrs, op.attr_set.name)
> +        msg['msg'] = attrs
>          self.async_msg_queue.append(msg)