netdev - Re: [PATCH net-next v3 7/8] net: txgbe: support copper NIC with external PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b142b43-65fa-465b-aa41-bd2200e71c63@lunn.ch>
Date: Thu, 24 Aug 2023 15:02:16 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, hkallweit1@...il.com,
	linux@...linux.org.uk, Jose.Abreu@...opsys.com,
	rmk+kernel@...linux.org.uk, mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v3 7/8] net: txgbe: support copper NIC with
 external PHY

On Thu, Aug 24, 2023 at 10:00:41AM +0800, Jiawen Wu wrote:
> On Wednesday, August 23, 2023 11:36 PM, Andrew Lunn wrote:
> > > +static int txgbe_phy_read(struct mii_bus *bus, int phy_addr,
> > > +			  int devnum, int regnum)
> > 
> > There is a general pattern to use the postfix _c45 for the method that
> > implements C45 access. Not a must, just a nice to have.
> > 
> > Does this bus master not support C22 at all?
> 
> It supports C22.

I was looking at how the two MDIO bus master implementations
differ. Once difference is a register write to set C22/C45, which this
code does not have. The second change appears to be a clock setting.

If you added C22, do the two become more similar? Should this actually
be one implementation in the library?

	Andrew