netdev - Re: [net-next v2 5/5] net: wwan: t7xx: Devlink documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230824154705.GK3523530@kernel.org>
Date: Thu, 24 Aug 2023 17:47:05 +0200
From: Simon Horman <horms@...nel.org>
To: Jinjian Song <songjinjian@...mail.com>
Cc: netdev@...r.kernel.org, chandrashekar.devegowda@...el.com,
	chiranjeevi.rapolu@...ux.intel.com, danielwinkler@...gle.com,
	davem@...emloft.net, edumazet@...gle.com, haijun.liu@...iatek.com,
	ilpo.jarvinen@...ux.intel.com, jesse.brandeburg@...el.com,
	jinjian.song@...ocom.com, johannes@...solutions.net,
	kuba@...nel.org, linuxwwan@...el.com, linuxwwan_5g@...el.com,
	loic.poulain@...aro.org, m.chetan.kumar@...ux.intel.com,
	pabeni@...hat.com, ricardo.martinez@...ux.intel.com,
	ryazanov.s.a@...il.com, soumya.prakash.mishra@...el.com,
	nmarupaka@...gle.com, vsankar@...ovo.com
Subject: Re: [net-next v2 5/5] net: wwan: t7xx: Devlink documentation

On Wed, Aug 23, 2023 at 10:21:29PM +0800, Jinjian Song wrote:
> From: Jinjian Song <jinjian.song@...ocom.com>
> 
> Document the t7xx devlink commands usage for firmware flashing &
> coredump collection.
> 
> Base on the v5 patch version of follow series:
> 'net: wwan: t7xx: fw flashing & coredump support'
> (https://patchwork.kernel.org/project/netdevbpf/patch/f902d4a0cb807a205687f7e693079fba72ca7341.1674307425.git.m.chetan.kumar@linux.intel.com/)
> 
> Signed-off-by: Jinjian Song <jinjian.song@...ocom.com>

Hi Jinjian Song,

some minor feedback from my side.

...

> +
> +Coredump Collection
> +~~~~~~~~~~~~~~~~~~

nit: the line above seems to need one more '~'

> +
> +::
> +
> +  $ devlink region new mr_dump
> +
> +::
> +
> +  $ devlink region read mr_dump snapshot 0 address 0 length $len
> +
> +::
> +
> +  $ devlink region del mr_dump snapshot 0
> +
> +Note: $len is actual len to be dumped.
> +
> +The userspace application uses these commands for obtaining the modem component
> +logs when device encounters an exception.
> +
> +Second Stage Bootloader dump
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~

Ditto.

> +
> +::
> +
> +  $ devlink region new lk_dump
> +
> +::
> +
> +  $ devlink region read lk_dump snapshot 0 address 0 length $len
> +
> +::
> +
> +  $ devlink region del lk_dump snapshot 0
> +
> +Note: $len is actual len to be dumped.
> +
> +In fastboot mode the userspace application uses these commands for obtaining the
> +current snapshot of second stage bootloader.
> +
> -- 
> 2.34.1
> 
>