netdev - Re: [PATCH net-next v5 10/10] net: axienet: Introduce dmaengine support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230823181012.0a46d96a@kernel.org>
Date: Wed, 23 Aug 2023 18:10:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
Cc: "vkoul@...nel.org" <vkoul@...nel.org>, "robh+dt@...nel.org"
 <robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org"
 <krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org"
 <conor+dt@...nel.org>, "Simek, Michal" <michal.simek@....com>,
 "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "linux@...linux.org.uk" <linux@...linux.org.uk>,
 "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>
Subject: Re: [PATCH net-next v5 10/10] net: axienet: Introduce dmaengine
 support

On Wed, 23 Aug 2023 17:38:58 +0000 Pandey, Radhey Shyam wrote:
> > The kmemcache is not the worst possible option but note that the
> > objects you're allocating (with zeroing) are 512+ bytes. That's
> > pretty large, when most packets will not have full 16 fragments.
> > Ring buffer would allow to better match the allocation size to
> > the packets. Not to mention that it can be done fully locklessly.  
> 
> I modified the implementation to use a circular ring buffer for TX
> and RX. It seems to be working in initial testing and now running 
> perf tests.
> 
> Just had one question on when to submit v6 ? Wait till dmaengine
> patches([01/10-[07/10] is part of net-next? Or can I send it now also.

Assuming Linus cuts final this Sunday - after Sept 10th.