netdev - Re: [PATCH v6 1/5] dt-bindings: net: Add ICSS IEP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5a343c8-c384-6eea-94bf-e0c4f96e5fb0@linaro.org>
Date: Thu, 24 Aug 2023 08:43:52 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: MD Danish Anwar <danishanwar@...com>, Randy Dunlap
 <rdunlap@...radead.org>, Roger Quadros <rogerq@...nel.org>,
 Simon Horman <simon.horman@...igine.com>,
 Vignesh Raghavendra <vigneshr@...com>, Andrew Lunn <andrew@...n.ch>,
 Richard Cochran <richardcochran@...il.com>,
 Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Rob Herring <robh+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 "David S. Miller" <davem@...emloft.net>
Cc: nm@...com, srk@...com, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, netdev@...r.kernel.org,
 linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 1/5] dt-bindings: net: Add ICSS IEP

On 23/08/2023 13:32, MD Danish Anwar wrote:
> Add a DT binding document for the ICSS Industrial Ethernet Peripheral(IEP)
> hardware. IEP supports packet timestamping, PTP and PPS.
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Really? Where?

> Reviewed-by: Roger Quadros <rogerq@...nel.org>

Now you are making things up. Please stop faking tags.

> Reviewed-by: Simon Horman <horms@...nel.org>

Where?

> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---
>  .../devicetree/bindings/net/ti,icss-iep.yaml  | 61 +++++++++++++++++++
>  1 file changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
> new file mode 100644
> index 000000000000..75668bea8614
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module
> +
> +maintainers:
> +  - Md Danish Anwar <danishanwar@...com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - ti,am642-icss-iep
> +              - ti,j721e-icss-iep
> +          - const: ti,am654-icss-iep
> +
> +      - const: ti,am654-icss-iep
> +
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +    description: phandle to the IEP source clock
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +

Drop stray blank line

> +    /* AM65x */
> +    icssg0_iep0: iep@...00 {
> +        compatible = "ti,am654-icss-iep";
> +        reg = <0x2e000 0x1000>;
> +        clocks = <&icssg0_iepclk_mux>;
> +    };

Choose one example.

Best regards,
Krzysztof