netdev - Re: [PATCH v6 4/5] net: ti: icssg-prueth: add packet timestamping and ptp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d07213a9-6cf5-3577-a2c7-d0f2773a8247@linaro.org>
Date: Thu, 24 Aug 2023 08:47:41 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: MD Danish Anwar <danishanwar@...com>, Randy Dunlap
 <rdunlap@...radead.org>, Roger Quadros <rogerq@...nel.org>,
 Simon Horman <simon.horman@...igine.com>,
 Vignesh Raghavendra <vigneshr@...com>, Andrew Lunn <andrew@...n.ch>,
 Richard Cochran <richardcochran@...il.com>,
 Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Rob Herring <robh+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 "David S. Miller" <davem@...emloft.net>
Cc: nm@...com, srk@...com, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, netdev@...r.kernel.org,
 linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 4/5] net: ti: icssg-prueth: add packet timestamping and
 ptp support

On 23/08/2023 13:32, MD Danish Anwar wrote:
> From: Roger Quadros <rogerq@...com>
> 
> Add packet timestamping TS and PTP PHC clock support.
> 
> For AM65x and AM64x:
>  - IEP1 is not used
>  - IEP0 is configured in shadow mode with 1ms cycle and shared between
> Linux and FW. It provides time and TS in number cycles, so special
> conversation in ns is required.
>  - IEP0 shared between PRUeth ports.
>  - IEP0 supports PPS, periodic output.
>  - IEP0 settime() and enabling PPS required FW interraction.
>  - RX TS provided with each packet in CPPI5 descriptor.
>  - TX TS returned through separate ICSSG hw queues for each port. TX TS
> readiness is signaled by INTC IRQ. Only one packet at time can be requested
> for TX TS.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> Co-developed-by: Grygorii Strashko <grygorii.strashko@...com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> Reviewed-by: Roger Quadros <rogerq@...nel.org>

How patch author could review or not review its own code? How does it
even work? I write a patch and for example judge - oh no, it is wrong,
but I will still send it, just without my review. Or I write a patch -
oh, I like it, I wrote excellent code, let me add review tag for my own
code!

> Reviewed-by: Simon Horman <horms@...nel.org>

Where?

Best regards,
Krzysztof