netdev - Re: [EXTERNAL] Re: [PATCH v6 4/5] net: ti: icssg-prueth: add packet timestamping and ptp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ef0017f-9ba2-2ac1-702e-a9194f75652f@ti.com>
Date: Thu, 24 Aug 2023 12:26:12 +0530
From: Md Danish Anwar <a0501179@...com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        MD Danish Anwar
	<danishanwar@...com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Roger Quadros
	<rogerq@...nel.org>,
        Simon Horman <simon.horman@...igine.com>,
        Vignesh
 Raghavendra <vigneshr@...com>, Andrew Lunn <andrew@...n.ch>,
        Richard Cochran
	<richardcochran@...il.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring
	<robh+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski
	<kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller"
	<davem@...emloft.net>
CC: <nm@...com>, <srk@...com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXTERNAL] Re: [PATCH v6 4/5] net: ti: icssg-prueth: add packet
 timestamping and ptp support

On 24/08/23 12:17 pm, Krzysztof Kozlowski wrote:
> On 23/08/2023 13:32, MD Danish Anwar wrote:
>> From: Roger Quadros <rogerq@...com>
>>
>> Add packet timestamping TS and PTP PHC clock support.
>>
>> For AM65x and AM64x:
>>  - IEP1 is not used
>>  - IEP0 is configured in shadow mode with 1ms cycle and shared between
>> Linux and FW. It provides time and TS in number cycles, so special
>> conversation in ns is required.
>>  - IEP0 shared between PRUeth ports.
>>  - IEP0 supports PPS, periodic output.
>>  - IEP0 settime() and enabling PPS required FW interraction.
>>  - RX TS provided with each packet in CPPI5 descriptor.
>>  - TX TS returned through separate ICSSG hw queues for each port. TX TS
>> readiness is signaled by INTC IRQ. Only one packet at time can be requested
>> for TX TS.
>>
>> Signed-off-by: Roger Quadros <rogerq@...com>
>> Co-developed-by: Grygorii Strashko <grygorii.strashko@...com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
>> Reviewed-by: Roger Quadros <rogerq@...nel.org>
> 
> How patch author could review or not review its own code? How does it
> even work? I write a patch and for example judge - oh no, it is wrong,
> but I will still send it, just without my review. Or I write a patch -
> oh, I like it, I wrote excellent code, let me add review tag for my own
> code!
> 

He didn't review this patch explicitly. He gave RB for entire series, b4 [1]
must have added his RB to all patches instead of only adding to those patches
for which he is not the author. I will manually remove his RBs in the patches
where he is the author.

[1] https://b4.docs.kernel.org/en/latest/index.html

>> Reviewed-by: Simon Horman <horms@...nel.org>
> 
> Where?
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Thanks and Regards,
Danish.