netdev - Re: [RFC net-next v2 3/5] net: phy: nxp-c45-tja11xx add MACsec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1baef3d-ad81-5e10-6b8f-7578b3b8d5b8@oss.nxp.com>
Date: Fri, 25 Aug 2023 16:44:19 +0300
From: "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
To: Andrew Lunn <andrew@...n.ch>, Sabrina Dubroca <sd@...asysnail.net>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 richardcochran@...il.com, sebastian.tobuschat@....com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC net-next v2 3/5] net: phy: nxp-c45-tja11xx add MACsec
 support



On 25.08.2023 16:29, Andrew Lunn wrote:

>>> +static bool nxp_c45_rx_sc_valid(struct nxp_c45_secy *phy_secy,
>>> +				struct macsec_rx_sc *rx_sc)
>>> +{
>>> +	u16 port =  (__force u64)rx_sc->sci >> (ETH_ALEN * 8);
>>
>> u64 sci = be64_to_cpu((__force __be64)rx_sc->sci);
> 
> why is the __force needed? What happens with a normal cast?
> 

Sparse will print warnings if __force is missing.

>      Andrew
> 

-- 
Radu P.