netdev - RE: [PATCH 2/2] net: dsa: microchip: Provide Module 4 KSZ9477 errata (DS80000754C)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 25 Aug 2023 18:48:41 +0000
From: <Tristram.Ha@...rochip.com>
To: <f.fainelli@...il.com>
CC: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <Woojung.Huh@...rochip.com>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>,
	<lukma@...x.de>
Subject: RE: [PATCH 2/2] net: dsa: microchip: Provide Module 4 KSZ9477 errata
 (DS80000754C)

> > IMHO adding functions to MMD modification would facilitate further
> > development (for example LED setup).
> 
> We already have some KSZ9477 specific initialization done in the Micrel
> PHY driver under drivers/net/phy/micrel.c, can we converge on the PHY
> driver which has a reasonable amount of infrastructure for dealing with
> workarounds, indirect or direct MMD accesses etc.?

Actually the internal PHY used in the KSZ9897/KSZ9477/KSZ9893 switches
are special and only used inside those switches.  Putting all the switch
related code in Micrel PHY driver does not really help.  When the switch
is reset all those PHY registers need to be set again, but the PHY driver
only executes those code during PHY initialization.  I do not know if
there is a good way to tell the PHY to re-initialize again.
There is also a typo in one of those registers when the code was moved
to the Micrel PHY driver.  A fix will be needed.