netdev - RE: [PATCH RFC net-next v1 2/2] selftests/dpll: add DPLL system integration selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH3PR11MB8414200922FA16348A4F36C9E3E3A@CH3PR11MB8414.namprd11.prod.outlook.com>
Date: Fri, 25 Aug 2023 19:06:55 +0000
From: "Michalik, Michal" <michal.michalik@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>,
	"jonathan.lemon@...il.com" <jonathan.lemon@...il.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, poros <poros@...hat.com>, "Olech, Milena"
	<milena.olech@...el.com>, mschmidt <mschmidt@...hat.com>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>, "bvanassche@....org"
	<bvanassche@....org>
Subject: RE: [PATCH RFC net-next v1 2/2] selftests/dpll: add DPLL system
 integration selftests

On 24 August 2023 5:50 PM CEST, Jakub Kicinski wrote:
> 
> On Thu, 24 Aug 2023 08:59:53 +0000 Michalik, Michal wrote:
>> >> The biggest concern for me is the requirement of selftests[2]:
>> >>   "Don't take too long;"
>> >> This approach is reloading the modules few times to check few scenarios.
>> >> Also, the DPLL subsystem is being tested against multiple requests - so
>> >> it takes some time to finish (not too long but is definitely not instant).  
>> > 
>> > I think the time constraints are more of a question of practicality.
>> > A developer should be able to run the tests as part of their workflow.
>> 
>> That makes sense - agree. So Jakub, if I understand correctly we have a few
>> different problems to solve here:
>> 1) how to deploy the module:
>>  - now it's separated, we should consider e.g. netdevsim
>> 2) if we should have those tests a part of selftests
>>  - I would remove it from selftests and move it to ./tools/testing
>> 3) if we should use Python at all:
>>  - fast to develop and easy to maintain
>>  - might be problematic to deploy (no Python, VMs, embedded, no network etc.)
>>  
>> Do I understand our current outcome of the discussion correctly?
> 
> Yes, and on (3) unless someone objects let's stick to Python.

Please be kindly informed that I just start my 2 week vacations returning on 11th Sep.
Excuse me for the upcoming delay in preparing the v2 of the RFC.

All the best,
M^2