netdev - Re: [PATCH 28/29] xfs: support nowait semantics for xc_ctx_lock in xlog_cil

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOkkT5Ai7wyMGcWC@dread.disaster.area>
Date: Sat, 26 Aug 2023 07:59:43 +1000
From: Dave Chinner <david@...morbit.com>
To: Hao Xu <hao.xu@...ux.dev>
Cc: io-uring@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	Dominique Martinet <asmadeus@...ewreck.org>,
	Pavel Begunkov <asml.silence@...il.com>,
	Christian Brauner <brauner@...nel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Stefan Roesch <shr@...com>, Clay Harris <bugs@...ycon.org>,
	"Darrick J . Wong" <djwong@...nel.org>,
	linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-cachefs@...hat.com,
	ecryptfs@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-unionfs@...r.kernel.org, bpf@...r.kernel.org,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	linux-btrfs@...r.kernel.org, codalist@...a.cs.cmu.edu,
	linux-f2fs-devel@...ts.sourceforge.net, cluster-devel@...hat.com,
	linux-mm@...ck.org, linux-nilfs@...r.kernel.org,
	devel@...ts.orangefs.org, linux-cifs@...r.kernel.org,
	samba-technical@...ts.samba.org, linux-mtd@...ts.infradead.org,
	Wanpeng Li <wanpengli@...cent.com>
Subject: Re: [PATCH 28/29] xfs: support nowait semantics for xc_ctx_lock in
 xlog_cil_commit()

On Fri, Aug 25, 2023 at 09:54:30PM +0800, Hao Xu wrote:
> From: Hao Xu <howeyxu@...cent.com>
> 
> Apply trylock logic for xc_ctx_lock in xlog_cil_commit() in nowait
> case and error out -EAGAIN for xlog_cil_commit().

Again, fundamentally broken. Any error from xlog_cil_commit() will
result in a filesystem shutdown as we cannot back out from failure
with dirty log items gracefully at this point.

-Dave.

-- 
Dave Chinner
david@...morbit.com