netdev - Re: [net-next Patch 4/5] octeontx2-af: replace generic error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <PH0PR18MB44746523EE146CF2384EA063DEE3A@PH0PR18MB4474.namprd18.prod.outlook.com>
Date: Fri, 25 Aug 2023 07:20:09 +0000
From: Hariprasad Kelam <hkelam@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Sunil Kovvuri Goutham
	<sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin
 Jacob Kollanukkaran <jerinj@...vell.com>,
        Linu Cherian
	<lcherian@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Naveen Mamindlapalli <naveenm@...vell.com>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [net-next Patch 4/5] octeontx2-af: replace generic error codes



> On Thu, 24 Aug 2023 05:41:01 +0000 Hariprasad Kelam wrote:
> > > > The custom error codes are not liked upstream, they make much
> > > > harder for people who don't work on the driver to refactor it.
> > > >
> > > > If you want debugging isn't it better to add a tracepoint to the checks?
> > >
> > > Hari>>  These error codes are added in AF mailbox handlers, user
> > > Hari>> space tools
> > > like ethool ,tc won't see these since these are between pf netdev and
> AF.
> > > During netdev driver probe/open calls, it requests AF driver to
> > > configure different hardware blocks MAC/network etc. If there is any
> > > error instead of getting EPERM, we will get block specific error
> > > codes like LMAC_AF_ERR_INVALID_PARAM, NIX_AF_ERR_PARAM etc.
> >
> > Jakub,
> > Any comments here?
> 
> Please learn how to use email correctly.
> 
> Hari>>
> 
> Makes the entire line rendered as a quote in many email clients, because the
> gt than sign is a quote marker.

   ACK
> 
> You should also wrap your lines.
> 
> If you want to return the block which failed to the caller you can do that, but
> not instead of the error code.

Ok, will remove this patch from the series.

Thanks,
Hariprasad k