netdev - Re: [PATCH net-next v5 11/12] doc/netlink: Add spec for rt link messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2y1hzebmz.fsf@gmail.com>
Date: Fri, 25 Aug 2023 10:04:20 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org,  Jakub Kicinski <kuba@...nel.org>,  "David S.
 Miller" <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Paolo
 Abeni <pabeni@...hat.com>,  Jonathan Corbet <corbet@....net>,
  linux-doc@...r.kernel.org,  Stanislav Fomichev <sdf@...gle.com>,
  Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
  donald.hunter@...hat.com,  Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH net-next v5 11/12] doc/netlink: Add spec for rt link
 messages

Jiri Pirko <jiri@...nulli.us> writes:

> Thu, Aug 24, 2023 at 01:20:02PM CEST, donald.hunter@...il.com wrote:
>
> [...]
>
>>+attribute-sets:
>>+  -
>>+    name: link-attrs
>>+    name-prefix: ifla-
>>+    attributes:
>>+      -
>>+        name: address
>>+        type: binary
>>+        display-hint: mac
>>+        value: 1
>>+      -
>>+        name: broadcast
>>+        type: binary
>>+        display-hint: mac
>>+        value: 2
>
> Why do you specify value here? In general, it is not needed if it
> is the prev+1.

I added the values when I generated some of the spec contents from
btftool output and they were helpful for visual lookup when I was
working on the spec.

I can remove them.

>>+      -
>>+        name: ifname
>>+        type: string
>>+        value: 3
>
> [...]