netdev - RE: [PATCH net] net: read sk->sk_family once in sk_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cc17b1240c94bc2b44364e67afb838e@AcuMS.aculab.com>
Date: Mon, 28 Aug 2023 14:21:47 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Eric Dumazet' <edumazet@...gle.com>, "David S . Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>, syzbot
	<syzkaller@...glegroups.com>
Subject: RE: [PATCH net] net: read sk->sk_family once in sk_mc_loop()

From: Eric Dumazet
> Sent: 28 August 2023 12:31
> 
> syzbot is playing with IPV6_ADDRFORM quite a lot these days,
> and managed to hit the WARN_ON_ONCE(1) in sk_mc_loop()
> 
> We have many more similar issues to fix.

Is it worth revisiting the use of volatile?
If all accesses to a field have to be marked READ_ONCE()
and WRITE_ONCE() then isn't that just 'volatile'?

IIRC READ_ONCE() (well ACCESS_ONCE()) was originally only
used to stop the compiler re-reading a value.
The current code also worries about the compiler generating
non-atomic read/write (even to a 32bit word).
So typically all references end up being annotated.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)