netdev - Re: [PATCH net v3 1/3] ipv4: ignore dst hint for multipath routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecba2119-2182-16b5-9ad5-25a9b497b0d6@kernel.org>
Date: Mon, 28 Aug 2023 12:55:57 -0600
From: David Ahern <dsahern@...nel.org>
To: Sriram Yagnaraman <sriram.yagnaraman@....tech>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Ido Schimmel <idosch@...dia.com>,
 Shuah Khan <shuah@...nel.org>, Petr Machata <petrm@...dia.com>
Subject: Re: [PATCH net v3 1/3] ipv4: ignore dst hint for multipath routes

On 8/28/23 5:32 AM, Sriram Yagnaraman wrote:
> Route hints when the nexthop is part of a multipath group causes packets
> in the same receive batch to be sent to the same nexthop irrespective of
> the multipath hash of the packet. So, do not extract route hint for
> packets whose destination is part of a multipath group.
> 
> A new SKB flag IPSKB_MULTIPATH is introduced for this purpose, set the
> flag when route is looked up in ip_mkroute_input() and use it in
> ip_extract_route_hint() to check for the existence of the flag.
> 
> Fixes: 02b24941619f ("ipv4: use dst hint for ipv4 list receive")
> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@....tech>
> ---
>  include/net/ip.h    | 1 +
>  net/ipv4/ip_input.c | 3 ++-
>  net/ipv4/route.c    | 1 +
>  3 files changed, 4 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>