netdev - Re: [PATCH net-next] docs: netdev: document patchwork patch states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 28 Aug 2023 12:23:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, corbet@....net, workflows@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next] docs: netdev: document patchwork patch states

On Mon, 28 Aug 2023 22:09:11 +0300 Laurent Pinchart wrote:
> > +New, Under review  pending review, patch is in the maintainer’s queue for review  
> 
> Is there a meaningful distinction between "New" and "Under review", or
> are they exactly the same ? The former sounds like nobody has looked at
> the patch yet, while the latter seems to indicate someone has assigned
> the task of reviewing the patch to themselves, but maybe netdev uses
> those two states differently ?

The honest answer is that I don't know. I used to think that the
distinction is as you described - after someone done the initial triage
on the patch it goes New -> Under review.

But there's little consistency with that happening and it's unclear what
"initial triage" constitutes at this stage, so for all practical
purposes New == Under review.

> > +Accepted           patch was applied to the appropriate networking tree, this is
> > +                   usually set automatically by the pw-bot
> > +Needs ACK          waiting for an ack from an area maintainer or testing  
> 
> How does this differ from "Under review" ?

This indicates that netdev maintainers are waiting for someone who
is not a netdev maintainer. Let me s/maintainer/expert/ to make that
clearer-ish.