netdev - Re: ltp testcases failed due to commit cf3128a7aca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZOwPIczX73/22a35@gondor.apana.org.au>
Date: Mon, 28 Aug 2023 11:06:09 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: mengkanglai <mengkanglai2@...wei.com>
Cc: Steffen Klassert <steffen.klassert@...unet.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Fengtao (fengtao, Euler)" <fengtao40@...wei.com>,
	"Yanan (Euler)" <yanan@...wei.com>
Subject: Re: ltp testcases failed due to commit cf3128a7aca

On Mon, Aug 28, 2023 at 02:12:12AM +0000, mengkanglai wrote:
>
> This command eventually use setkey -c to add spdadd entry failed:
> spdadd $src_ipaddr $dst_ipaddr any
> 　　-P out ipsec $protocol/tunnel/${src_ipaddr}-${dst_ipaddr}/use ; 
> 
> It returns Invalid argument.
> 
> I found this failed due to commit cf3128a7aca(af_key: Reject optional tunnel/BEET mode templates in outbound policies), is latest ltp testcases are not adapted? 

Correct.  The above specification makes no sense for an outbound
policy as the SA can only be optional for inbound (where IPComp
can be skipped for incompressible plaintext).  So change the word
"use" above to "require" and it should work.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt