netdev - Re: [PATCH] KEYS: Include linux/errno.h in linux/verification.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8481f02f-7dad-0459-bd2e-536ff8ab6896@iogearbox.net>
Date: Mon, 28 Aug 2023 11:33:04 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Herbert Xu <herbert@...dor.apana.org.au>,
 kernel test robot <lkp@...el.com>
Cc: Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
 Eric Biggers <ebiggers@...nel.org>, "Theodore Y.Ts'o" <tytso@....edu>,
 Jaegeuk Kim <jaegeuk@...nel.org>, linux-fscrypt@...r.kernel.org,
 Richard Weinberger <richard@....at>, linux-mtd@...ts.infradead.org,
 Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 linux-bluetooth@...r.kernel.org, Ilya Dryomov <idryomov@...il.com>,
 Xiubo Li <xiubli@...hat.com>, Jeff Layton <jlayton@...nel.org>,
 ceph-devel@...r.kernel.org, Steffen Klassert <steffen.klassert@...unet.com>,
 "David S. Miller" <davem@...emloft.net>,
 Johannes Berg <johannes@...solutions.net>, linux-wireless@...r.kernel.org,
 Matthieu Baerts <matthieu.baerts@...sares.net>,
 Mat Martineau <martineau@...nel.org>, Chuck Lever <chuck.lever@...cle.com>,
 Neil Brown <neilb@...e.de>, linux-nfs@...r.kernel.org,
 Mimi Zohar <zohar@...ux.ibm.com>, linux-inte@....codeaurora.org,
 grity@...r.kernel.org, "Jason A.Donenfeld" <Jason@...c4.com>,
 Ayush Sawal <ayush.sawal@...lsio.com>, llvm@...ts.linux.dev,
 oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
 David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org
Subject: Re: [PATCH] KEYS: Include linux/errno.h in linux/verification.h

Hi Herbert,

On 8/26/23 10:36 AM, Herbert Xu wrote:
> On Sat, Aug 26, 2023 at 02:58:48PM +0800, kernel test robot wrote:
>>
>> All errors (new ones prefixed by >>):
>>
>>     In file included from fs/ubifs/auth.c:12:
>>>> include/linux/verification.h:23:11: error: use of undeclared identifier 'EINVAL'
> 
> ---8<---
> Add inclusion of linux/errno.h as otherwise the reference to EINVAL
> may be invalid.
> 
> Fixes: f3cf4134c5c6 ("bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308261414.HKw1Mrip-lkp@intel.com/
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> diff --git a/include/linux/verification.h b/include/linux/verification.h
> index f34e50ebcf60..cb2d47f28091 100644
> --- a/include/linux/verification.h
> +++ b/include/linux/verification.h
> @@ -8,6 +8,7 @@
>   #ifndef _LINUX_VERIFICATION_H
>   #define _LINUX_VERIFICATION_H
>   
> +#include <linux/errno.h>
>   #include <linux/types.h>
>   
>   /*
> 

Looks good, do you plan to route this fix to Linus?

Thanks,
Daniel